Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to SDoE Documentation Examples Pages #1160

Merged
merged 15 commits into from
Sep 5, 2023
Merged

Updates to SDoE Documentation Examples Pages #1160

merged 15 commits into from
Sep 5, 2023

Conversation

mirandamartin
Copy link
Contributor

Fixes/Addresses:

Updated examples in SDoE documentation (updating screenshots, example files, results).

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (807ac6b) 37.22% compared to head (34de1b7) 37.23%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
+ Coverage   37.22%   37.23%   +0.01%     
==========================================
  Files         160      160              
  Lines       36339    36339              
  Branches     5944     5944              
==========================================
+ Hits        13527    13531       +4     
+ Misses      21730    21728       -2     
+ Partials     1082     1080       -2

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sotorrio1
sotorrio1 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@sotorrio1 sotorrio1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Aug 29, 2023
@ksbeattie
Copy link
Member

@sotorrio1 a/o @mirandamartin is this part of any of our milestones?

@ksbeattie ksbeattie merged commit 0d1e950 into CCSI-Toolset:master Sep 5, 2023
@ksbeattie
Copy link
Member

@sotorrio1 a/o @mirandamartin is this part of any of our milestones?

I've placed this under milestone https://github.com/CCSI-Toolset/FOQUS/milestone/37, which is somewhat of a stretch, but feel free to disagree.

@sotorrio1
Copy link
Member

@sotorrio1 a/o @mirandamartin is this part of any of our milestones?

I've placed this under milestone https://github.com/CCSI-Toolset/FOQUS/milestone/37, which is somewhat of a stretch, but feel free to disagree.

It's kind of a stretch but I'm OK with it. I don't believe Miranda's work responded to any specific milestones, it was more something we needed to do to reflect latest updates to the GUI and visualizations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotorrio1 sotorrio1 sotorrio1 approved these changes

Assignees

@mirandamartin mirandamartin

Labels
Priority:High High Priority Issue or PR
Projects
None yet
Milestone
EY23.4.1.I: SDoE FOQUS Cloud support ...
Development

Successfully merging this pull request may close these issues.
3 participants
@mirandamartin @ksbeattie @sotorrio1